Stardew Valley: Fix a bug in equals between Or and And rules #4326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
waiting-on: peer-review
|
|
Jouramie
added a commit
to agilbert1412/Archipelago
that referenced
this pull request
Dec 15, 2024
…agoMW#4326 (cherry picked from commit 6896d63)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
So, I don't know how it went unnoticed for so long... Basically for
OrandAndrule, if two rules had the same combinable sub-rules, they would automatically be considered equals completely ignoring the other sub-rules. For example, a rule that require access to 5 regions would be considered equal to a different rule requiring 5 completely different regions. They would evaluate different, but be considered equal.I found this while writing tests in another branch. This bug has been merged for ~9 months and no one noticed, so I guess the
__eq__is probably not used too often. At least the__hash__is correctly implemented, so that probably saved a lot of problems.How was this tested?
Not really tested, but it's kind of obvious that the
__eq__method should compare withotherand notself.If this makes graphical changes, please attach screenshots.
N/A